]> xenbits.xensource.com Git - libvirt.git/commit
rpc: avoid unlinking sockets passed in from systemd
authorDaniel P. Berrangé <berrange@redhat.com>
Tue, 25 Jun 2019 19:17:27 +0000 (20:17 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Fri, 12 Jul 2019 15:55:39 +0000 (16:55 +0100)
commit1519c55dc81800cfcda572c44fc7546f4fb077ca
treeeed2e06a96093310533f89dd54ad58b7b48cf1d1
parent9f3d1c5c8f1f2c5531333148954179e5497b3db6
rpc: avoid unlinking sockets passed in from systemd

Currently the socket code will unlink any UNIX socket path which is
associated with a server socket. This is not fine grained enough, as we
need to avoid unlinking server sockets we were passed by systemd.

To deal with this we must explicitly track whether each socket needs to
be unlinked when closed, separately of the client vs server state.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
15 files changed:
src/locking/lock_daemon.c
src/logging/log_daemon.c
src/rpc/virnetserverservice.c
src/rpc/virnetserverservice.h
src/rpc/virnetsocket.c
src/rpc/virnetsocket.h
tests/virnetdaemondata/input-data-anon-clients.json
tests/virnetdaemondata/output-data-admin-server-names.json
tests/virnetdaemondata/output-data-admin.json
tests/virnetdaemondata/output-data-anon-clients.json
tests/virnetdaemondata/output-data-client-auth-pending.json
tests/virnetdaemondata/output-data-client-ids.json
tests/virnetdaemondata/output-data-client-timestamp.json
tests/virnetdaemondata/output-data-initial.json
tests/virnetdaemondata/output-data-no-keepalive-required.json