]> xenbits.xensource.com Git - libvirt.git/commit
qemu: Fix error reporting in qemuDomainSaveImageStartVM
authorJiri Denemark <jdenemar@redhat.com>
Tue, 18 Sep 2018 07:42:06 +0000 (09:42 +0200)
committerJiri Denemark <jdenemar@redhat.com>
Wed, 19 Sep 2018 12:05:59 +0000 (14:05 +0200)
commit1468536d423962241f5c30403b27a8c1d9a97b14
tree173857b89dae42dd04ea0f39285aa902b04c61d6
parent602ecdf2ab4b27d255c45e9980282f0c17ff6c2c
qemu: Fix error reporting in qemuDomainSaveImageStartVM

When restoring a domain from a compressed image, we launch an
intermediate process for decompressing the saved data. If QEMU fails to
load the data for some reason, we force close the stdin/stdout file
descriptors of the intermediate process and wait for it to die. However,
virCommandWait can report various errors which would overwrite the real
error from QEMU. Thus instead of getting something useful:

    internal error: process exited while connecting to monitor:
    2018-09-17T15:17:29.998910Z qemu-system-x86_64: can't apply global
    Skylake-Client-x86_64-cpu.osxsave=off: Property '.osxsave' not found

we could get an irrelevant error message:

    internal error: Child process (lzop -dc --ignore-warn) unexpected
    fatal signal 13

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
src/qemu/qemu_driver.c