]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commit
conf: Adjust invalid secrettype setting during parse
authorJohn Ferlan <jferlan@redhat.com>
Mon, 15 Jun 2015 14:40:27 +0000 (10:40 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Wed, 24 Jun 2015 10:20:52 +0000 (06:20 -0400)
commit13c59ac906b08ae74f520593d5ccf2dc65231c18
treed2c1bd4a07dd4ab41e8fd013a1cffbf2bf8b7244
parent5d8ef8ad670d52558bcfdc0e1ee3e76fb33cd5d1
conf: Adjust invalid secrettype setting during parse

Commit id '1feaccf0' attempted to handle an empty secrettype value; however,
it made a mistake by processing the secretType as if it was the original
secrettype string.  The 'secretType' is actually whether 'usage' or 'uuid'
was used.

Thus adjust part of the change to make the same check for def->src->type !=
VIR_STORAGE_TYPE_VOLUME before setting auth_secret_usage from the
secrettype field.

Luckily the aforementioned commits misdeed would be overwritten by the
call to virStorageTranslateDiskSourcePool
src/conf/domain_conf.c