]> xenbits.xensource.com Git - libvirt.git/commit
qemu: Fix GIC behavior for the default case
authorAndrea Bolognani <abologna@redhat.com>
Thu, 1 Feb 2018 16:52:48 +0000 (17:52 +0100)
committerAndrea Bolognani <abologna@redhat.com>
Tue, 13 Feb 2018 13:40:03 +0000 (14:40 +0100)
commit132548efde76defaca54f90cc9c8a57508a4a86f
treeb3868112e7970738d49c4e96f94a922b4ae3f7dc
parent7500533c5629c4864ae6cfa6672ff28f36e7010f
qemu: Fix GIC behavior for the default case

When no GIC version is specified, we currently default to GIC v2;
however, that's not a great default, since guests will fail to
start if the hardware only supports GIC v3.

Change the behavior so that a sensible default is chosen instead.
That basically means using the same algorithm whether the user
didn't explicitly enable the GIC feature or they explicitly
enabled it but didn't specify any GIC version.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
src/qemu/qemu_domain.c
tests/qemuxml2argvdata/aarch64-gic-default-both.args
tests/qemuxml2argvdata/aarch64-gic-default-v3.args
tests/qemuxml2xmloutdata/aarch64-gic-default-both.xml
tests/qemuxml2xmloutdata/aarch64-gic-default-v3.xml