]> xenbits.xensource.com Git - qemu-upstream-4.3-testing.git/commit
main loop: Big hammer to fix logfile disk DoS in Xen setups
authorIan Jackson <ian.jackson@eu.citrix.com>
Thu, 26 May 2016 15:21:56 +0000 (16:21 +0100)
committerAnthony PERARD <anthony.perard@citrix.com>
Fri, 10 Jun 2016 11:16:15 +0000 (12:16 +0100)
commit12e8fccf5b5460be7aecddc71d27eceaba6e1f15
tree078259c4f7dc669b0984fd8555def24bafd87841
parent0aabf85123a437e60e6cfb15f13bc559b75a21d5
main loop: Big hammer to fix logfile disk DoS in Xen setups

Each time round the main loop, we now fstat stderr.  If it is too big,
we dup2 /dev/null onto it.  This is not a very pretty patch but it is
very simple, easy to see that it's correct, and has a low risk of
collateral damage.

There is no limit by default but can be adjusted by setting a new
environment variable.

This fixes CVE-2014-3672.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Tested-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Set the default to 0 so that it won't affect non-xen installation. The
limit will be set by Xen toolstack.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
(cherry picked from commit 44a072f0de0d57c95c2212bbce02888832b7b74f)
main-loop.c