]> xenbits.xensource.com Git - libvirt.git/commit
conf: backup: Fix logic for generating default backup filenames
authorPeter Krempa <pkrempa@redhat.com>
Mon, 15 May 2023 12:20:16 +0000 (14:20 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 16 May 2023 08:26:33 +0000 (10:26 +0200)
commit1222ada2afe62279ce4c8844694b3cb756ddd60b
tree21bcff7ed5fcfbc9e24118a2f0b130a277ef78cf
parentde48ade19586fda704d4f517ffb219960c3d6a08
conf: backup: Fix logic for generating default backup filenames

If the 'disk->store' property is already allocated which happens e.g.
when the disk is described by the backup XML but the optional filename
is not filled in 'virDomainBackupDefAssignStore' would not fill in the
default location.

Fix the logic to do it also if a 'virStorageSource' categorizes as
empty.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/conf/backup_conf.c
tests/domainbackupxml2xmlin/backup-push.xml
tests/domainbackupxml2xmlout/backup-push.xml