]> xenbits.xensource.com Git - seabios.git/commit
Revert "Use the extra stack for 16bit USB and PS2 keyboard/mouse commands."
authorKevin O'Connor <kevin@koconnor.net>
Tue, 30 Sep 2014 13:17:14 +0000 (09:17 -0400)
committerKevin O'Connor <kevin@koconnor.net>
Tue, 30 Sep 2014 13:42:54 +0000 (09:42 -0400)
commit12085439561f44107c7d3bea5a333a90ea987643
treead350bf1d6813cc7c38b8873838c19ce086242e5
parent67d1fbef0f630e1e823f137d1bae7fa5790bcf4e
Revert "Use the extra stack for 16bit USB and PS2 keyboard/mouse commands."

It's not valid to pass a pointer to a stack variable through the
stack_hop() call (because the call changes the stack segment).  This
bug was probably not noticed before because by default
(CONFIG_ENTRY_EXTRASTACK) SeaBIOS uses the extra stack on all 16bit
entry points, and the internal stack_hop() with that config option is
effectively a no-op.

This reverts commit d488a7683d90bf8fae7ceb8c3ad9e95fbbd92079.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
src/kbd.c
src/mouse.c