]> xenbits.xensource.com Git - qemu-xen.git/commit
qapi: Convert simple union ImageInfoSpecific to flat one
authorMarkus Armbruster <armbru@redhat.com>
Fri, 17 Sep 2021 14:31:20 +0000 (16:31 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Mon, 27 Sep 2021 06:23:25 +0000 (08:23 +0200)
commit0db4f50397ac518e3674d0a4fa73c3a3c823060d
tree1cb86997b04b3dd3ba995bfa2a17a08d0fe8a304
parent935a867c878d1450bf240caa18489649fcdff771
qapi: Convert simple union ImageInfoSpecific to flat one

Simple unions predate flat unions.  Having both complicates the QAPI
schema language and the QAPI generator.  We haven't been using simple
unions in new code for a long time, because they are less flexible and
somewhat awkward on the wire.

To prepare for their removal, convert simple union ImageInfoSpecific
to an equivalent flat one.  Adds some boilerplate to the schema, which
is a bit ugly, but a lot easier to maintain than the simple union
feature.

Implicit enum ImageInfoSpecificKind becomes explicit.  It duplicates
part of enum BlockdevDriver.  We could reuse BlockdevDriver instead.

Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20210917143134.412106-10-armbru@redhat.com>
qapi/block-core.json