]> xenbits.xensource.com Git - qemu-upstream-4.2-testing.git/commit
qcow1: Validate L2 table size (CVE-2014-0222)
authorKevin Wolf <kwolf@redhat.com>
Thu, 5 Mar 2015 11:01:07 +0000 (11:01 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Thu, 5 Mar 2015 18:16:00 +0000 (18:16 +0000)
commit0d217199cbac67d2f1f4102a944f96bfcfabae15
tree8ccfbc08e91a993abb4409da84be85f3b0aacf9a
parentdf2adab2575fa19764b744edafea1a202f904912
qcow1: Validate L2 table size (CVE-2014-0222)

Too large L2 table sizes cause unbounded allocations. Images actually
created by qemu-img only have 512 byte or 4k L2 tables.

To keep things consistent with cluster sizes, allow ranges between 512
bytes and 64k (in fact, down to 1 entry = 8 bytes is technically
working, but L2 table sizes smaller than a cluster don't make a lot of
sense).

This also means that the number of bytes on the virtual disk that are
described by the same L2 table is limited to at most 8k * 64k or 2^29,
preventively avoiding any integer overflows.

Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
block/qcow.c