]> xenbits.xensource.com Git - libvirt.git/commit
domcaps: Check for architecture more wisely
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 8 Apr 2015 14:59:36 +0000 (16:59 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 17 Apr 2015 15:00:15 +0000 (17:00 +0200)
commit0af9325e6a06fd4478d4eebfcd92dfe7e2ec570c
tree0ace1e4c86f44b8d7c62b672192de22d1c9a0838
parent450a59ba569f571e499d618be4bfde064122f1fc
domcaps: Check for architecture more wisely

https://bugzilla.redhat.com/show_bug.cgi?id=1209948

So we have this bug. The virConnectGetDomainCapabilities() API
performs a couple of checks before it produces any result. One of
the checks is if the architecture requested by user can be run by
the binary (again user provided). However, the check is pretty
dumb. It merely compares if the default binary architecture
matches the one provided by user. However, a qemu binary can run
multiple architectures. For instance: qemu-system-ppc64 can run:
ppc, ppcle, ppc64, ppc64le and ppcemb. The default is ppc64, so
if user requested something else, like ppc64le, the check would
have failed without obvious reason.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_driver.c