]> xenbits.xensource.com Git - libvirt.git/commit
conf: Format managed property of hostdev-pci ports correctly
authorAndrea Bolognani <abologna@redhat.com>
Thu, 24 Mar 2022 18:07:40 +0000 (19:07 +0100)
committerAndrea Bolognani <abologna@redhat.com>
Tue, 5 Apr 2022 11:40:33 +0000 (13:40 +0200)
commit06f5c092b8a38a9d88c7ef01ee37891ad45cbdc8
tree34c6c3e168eecf504d4bcd1947565f7ff2b68828
parent77c638c3c780e2b094f9f31525693e6c2b383ff5
conf: Format managed property of hostdev-pci ports correctly

The property is parsed using virTristateBoolTypeFromString() but
formatted as if it was a regular bool, which results in the
following incorrect conversion:

  BOOL_ABSENT -> managed='no'
  BOOL_YES    -> managed='yes'
  BOOL_NO     -> managed='yes'

Use the virTristateBoolTypeToString() helper to ensure the
setting can survive a roundtrip conversion.

Fixes: 4b4a981d60d3372fb73bb3546ab1052844b2e3d5
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/virnetworkportdef.c
tests/virnetworkportxml2xmldata/plug-hostdev-pci-unmanaged.xml [new file with mode: 0644]
tests/virnetworkportxml2xmltest.c