]> xenbits.xensource.com Git - libvirt.git/commit
maint: reject raw close, popen in 'make syntax-check'
authorEric Blake <eblake@redhat.com>
Thu, 27 Jan 2011 22:16:14 +0000 (15:16 -0700)
committerEric Blake <eblake@redhat.com>
Sat, 29 Jan 2011 17:36:47 +0000 (10:36 -0700)
commit030ce43b4952a4ff37486f119caaea43f88f3699
tree95fe758f37ec43e67e8a446692099553cd9bb215
parente67ae619919acb654b96a6829d9161287f814e71
maint: reject raw close, popen in 'make syntax-check'

commit f1fe9671e was supposed to make sure we use files.h
macros to avoid double close, but it didn't work.

Meanwhile, virCommand is vastly superior to system(), fork(),
and popen() (also to virExec, but we haven't completed that
conversion), so enforce that, too.

* cfg.mk (sc_prohibit_close): Fix typo that excluded close, and
add pclose.
(sc_prohibit_fork_wrappers): New rule, for fork, system, and popen.
* .x-sc_prohibit_close: More exemptions.
* .x-sc_prohibit_fork_wrappers: New file.
* Makefile.am (syntax_check_exceptions): Ship new file.
* src/datatypes.c (virReleaseConnect): Tweak comment to avoid
false positive.
* src/util/files.h (VIR_CLOSE): Likewise.
.x-sc_prohibit_close
.x-sc_prohibit_fork_wrappers [new file with mode: 0644]
Makefile.am
cfg.mk
src/datatypes.c
src/util/files.h