]> xenbits.xensource.com Git - qemu-upstream-4.6-testing.git/commit
qdev-monitor: Unref device when device_add fails
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 10 Sep 2013 16:21:08 +0000 (18:21 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 9 Dec 2013 17:40:30 +0000 (11:40 -0600)
commit03060dc086ec8a75929b7bb58df9e67a305a810d
treed61e44e9c7e1c29e9df73300626046cdeb88a587
parent2cafbbf1e03b954dedd3643ab3a4ffe685a63ccf
qdev-monitor: Unref device when device_add fails

qdev_device_add() leaks the created device upon failure.  I suspect this
problem crept in because qdev_free() unparents the device but does not
drop a reference - confusing name.

Cc: qemu-stable@nongnu.org
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
(cherry picked from commit ee6abeb6ec08473713848ce9028110f1684853b7)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qdev-monitor.c