]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commit
Fix crash changing CDROM media
authorDaniel P. Berrange <berrange@redhat.com>
Mon, 25 Feb 2013 17:22:14 +0000 (17:22 +0000)
committerDaniel P. Berrange <berrange@redhat.com>
Tue, 26 Feb 2013 17:45:31 +0000 (17:45 +0000)
commit02b9097274d1330c2e1dca7f598880e09b5c2aa0
tree94e513ee257685db18aed4c20a280a384f06062e
parentb6176e5226a258f24eb823dffcb2b0b36c75cae6
Fix crash changing CDROM media

This change tried to fix a crash with changing CDROM media but
failed to actually do so

  commit d0172d2b1b5d865aaa042070d7c2d00effb2ff8c
  Author: Osier Yang <jyang@redhat.com>
  Date:   Tue Feb 19 20:27:45 2013 +0800

    qemu: Remove the shared disk entry if the operation is ejecting or updating

It was still accessing disk->src, when the entire 'disk' object
has been free'd already. Even if it weren't free'd, accessing
the 'src' value of virDomainDiskDef is not allowed without
first validating disk->type is file or block. Just remove the
broken code entirely.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
src/qemu/qemu_driver.c