]> xenbits.xensource.com Git - libvirt.git/commit
qemuDomainChangeEjectableMedia: Don't always remove managed PR daemon
authorPeter Krempa <pkrempa@redhat.com>
Wed, 18 Mar 2020 10:44:01 +0000 (11:44 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 19 Mar 2020 08:57:45 +0000 (09:57 +0100)
commit02797541283c2c57620606b083db21b38c69c5c1
tree980092c11d9df142241089b1281e8daa04c85b12
parent5ed97c22865c86ccca3802d24c9893dd1109ab34
qemuDomainChangeEjectableMedia: Don't always remove managed PR daemon

When changing media we'd attempt to remove the managed pr daemon even if
neither of the images involved in the media change used it. This caused
libvirtd to log a spurious error:

2020-03-18 01:41:19.832+0000: 643207: error : qemuMonitorJSONCheckError:412 : internal error: unable to execute QEMU command 'object-del': object 'pr-helper0' not found

With this patch we completely avoid calling the deletion code.

https://bugzilla.redhat.com/show_bug.cgi?id=1814486

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_hotplug.c