ia64/xen-unstable

changeset 3770:fe75fd018eb7

bitkeeper revision 1.1167 (420b96b4EStXs5M4SVJpHN9DT5wwkQ)

smp_send_stop sometimes reenabled interrupts. Make sure it doesn't.
author sos22@douglas.cl.cam.ac.uk
date Thu Feb 10 17:15:32 2005 +0000 (2005-02-10)
parents 523d096fe965
children 37ac5c3e6403
files xen/arch/x86/cdb.c
line diff
     1.1 --- a/xen/arch/x86/cdb.c	Thu Feb 10 17:06:57 2005 +0000
     1.2 +++ b/xen/arch/x86/cdb.c	Thu Feb 10 17:15:32 2005 +0000
     1.3 @@ -327,10 +327,6 @@ void
     1.4  		return;
     1.5  	}
     1.6  
     1.7 -	/* Try to make things a little more stable by disabling
     1.8 -	   interrupts while we're here. */
     1.9 -	local_irq_save(flags);
    1.10 -
    1.11  	/* We rely on our caller to ensure we're only on one processor
    1.12  	 * at a time... We should probably panic here, but given that
    1.13  	 * we're a debugger we should probably be a little tolerant of
    1.14 @@ -346,11 +342,15 @@ void
    1.15  	if (!atomic_dec_and_test(&xendbg_running)) {
    1.16  		printk("WARNING WARNING WARNING: Avoiding recursive xendbg.\n");
    1.17  		atomic_inc(&xendbg_running);
    1.18 -		local_irq_restore(flags);
    1.19  		return;
    1.20  	}
    1.21  
    1.22  	smp_send_stop();
    1.23 +
    1.24 +	/* Try to make things a little more stable by disabling
    1.25 +	   interrupts while we're here. */
    1.26 +	local_irq_save(flags);
    1.27 +
    1.28  	old_watchdog = watchdog_on;
    1.29  	watchdog_on = 0;
    1.30