ia64/xen-unstable
changeset 18867:a71c610cc9e6
Fix one timer range issue
According to the timer sematic, the timer can be executed at any timer
within [expires, expires_end], however, current implementation only allow
timer to be executed after expires_end, which is not conform to the timer
semantics.
This patch fix the the SPECpower score regression (~5% downgrade)
introduced by changeset 18744 "Change timer implementation to allow
variable 'slop'"
Signed-off-by: Yu Ke <ke.yu@intel.com>
According to the timer sematic, the timer can be executed at any timer
within [expires, expires_end], however, current implementation only allow
timer to be executed after expires_end, which is not conform to the timer
semantics.
This patch fix the the SPECpower score regression (~5% downgrade)
introduced by changeset 18744 "Change timer implementation to allow
variable 'slop'"
Signed-off-by: Yu Ke <ke.yu@intel.com>
| author | Keir Fraser <keir.fraser@citrix.com> |
|---|---|
| date | Thu Dec 04 14:12:08 2008 +0000 (2008-12-04) |
| parents | 12c0acf08caf |
| children | 1b173394f815 |
| files | xen/common/timer.c |
line diff
1.1 --- a/xen/common/timer.c Thu Dec 04 12:35:22 2008 +0000 1.2 +++ b/xen/common/timer.c Thu Dec 04 14:12:08 2008 +0000 1.3 @@ -396,7 +396,7 @@ static void timer_softirq_action(void) 1.4 1.5 /* Execute ready heap timers. */ 1.6 while ( (GET_HEAP_SIZE(heap) != 0) && 1.7 - ((t = heap[1])->expires_end < now) ) 1.8 + ((t = heap[1])->expires < now) ) 1.9 { 1.10 remove_from_heap(heap, t); 1.11 t->status = TIMER_STATUS_inactive; 1.12 @@ -404,7 +404,7 @@ static void timer_softirq_action(void) 1.13 } 1.14 1.15 /* Execute ready list timers. */ 1.16 - while ( ((t = ts->list) != NULL) && (t->expires_end < now) ) 1.17 + while ( ((t = ts->list) != NULL) && (t->expires < now) ) 1.18 { 1.19 ts->list = t->list_next; 1.20 t->status = TIMER_STATUS_inactive;