ia64/xen-unstable
changeset 9201:17e26f60e901
Fix order-of-evaluation issue in xc_domain_dumpcore. The intent is
to move blocks of memory 4096 pages at a time, and a buffer is
allocated for this. Unfortunately, the #define is without
parentheses and %/* are the same order and evaluated left to right.
Result: very big buffer being used 4 pages at a time.
Signed-off-by: Ben Thomas (bthomas@virtualiron.com)
to move blocks of memory 4096 pages at a time, and a buffer is
allocated for this. Unfortunately, the #define is without
parentheses and %/* are the same order and evaluated left to right.
Result: very big buffer being used 4 pages at a time.
Signed-off-by: Ben Thomas (bthomas@virtualiron.com)
author | kaf24@firebug.cl.cam.ac.uk |
---|---|
date | Thu Mar 09 11:16:46 2006 +0100 (2006-03-09) |
parents | a4dc14edd56b |
children | 37f3f5ad9110 |
files | tools/libxc/xc_core.c |
line diff
1.1 --- a/tools/libxc/xc_core.c Thu Mar 09 00:45:40 2006 +0100 1.2 +++ b/tools/libxc/xc_core.c Thu Mar 09 11:16:46 2006 +0100 1.3 @@ -6,7 +6,7 @@ 1.4 #include <zlib.h> 1.5 1.6 /* number of pages to write at a time */ 1.7 -#define DUMP_INCREMENT 4 * 1024 1.8 +#define DUMP_INCREMENT (4 * 1024) 1.9 #define round_pgup(_p) (((_p)+(PAGE_SIZE-1))&PAGE_MASK) 1.10 1.11 static int