ia64/xen-unstable

view patches/linux-2.6.16.13/net-gso-4-kill-warnon.patch @ 11472:3e31c5e160cf

[HVM] Fix an error when read from APIC registers like IRR, ISR and TMR.
From SDM3 spec, for APIC registers, all 32-bit registers should
be accessed using 128-bit aligned 32bit loads or stores.
And wider registers (64-bit or 256-bit) must be accessed using
multiple 32-bit loads or stores.

In old APIC virtualization code, we use IRR, ISR and TMR which are
256-bit registers as contiguous bit maps other than multiple 32-bit.

So guest always fetch error values.

Original patch was:
* Signed-off-by: Xiaohui Xin <xiaohui.xin@intel.com>
* Signed-off-by: Yunhong Jiang <yunhong.jiang@intel.com>
* Signed-off-by: Eddie Dong <eddie.dong@intel.com>

Signed-off-by: Keir Fraser <keir@xensource.com>
author kaf24@firebug.cl.cam.ac.uk
date Wed Sep 13 15:59:14 2006 +0100 (2006-09-13)
parents 9519445d9e9d
children
line source
1 508c578140642a641bb9b888369719c510ae2a00
2 diff --git a/net/core/dev.c b/net/core/dev.c
3 index e814a89..240773b 100644
4 --- a/net/core/dev.c
5 +++ b/net/core/dev.c
6 @@ -1087,11 +1087,6 @@ int skb_checksum_help(struct sk_buff *sk
7 goto out_set_summed;
9 if (unlikely(skb_shinfo(skb)->gso_size)) {
10 - static int warned;
11 -
12 - WARN_ON(!warned);
13 - warned = 1;
14 -
15 /* Let GSO fix up the checksum. */
16 goto out_set_summed;
17 }
18 @@ -1141,11 +1136,6 @@ struct sk_buff *skb_gso_segment(struct s
19 __skb_pull(skb, skb->mac_len);
21 if (unlikely(skb->ip_summed != CHECKSUM_HW)) {
22 - static int warned;
23 -
24 - WARN_ON(!warned);
25 - warned = 1;
26 -
27 if (skb_header_cloned(skb) &&
28 (err = pskb_expand_head(skb, 0, 0, GFP_ATOMIC)))
29 return ERR_PTR(err);