ia64/linux-2.6.18-xen.hg

changeset 729:f29bf0bf3e97

linux: re-order fbfront initialization

The helper thread shouldn't be started before xenfb_connect_backend(),
to avoid the thread using the potentially not yet initialized irq.

Signed-off-by: Jan Beulich <jbeulich@novell.com>
author Keir Fraser <keir.fraser@citrix.com>
date Wed Nov 19 13:15:08 2008 +0000 (2008-11-19)
parents 69fc220cd737
children 832aac894efd
files drivers/xen/fbfront/xenfb.c
line diff
     1.1 --- a/drivers/xen/fbfront/xenfb.c	Wed Nov 19 13:14:11 2008 +0000
     1.2 +++ b/drivers/xen/fbfront/xenfb.c	Wed Nov 19 13:15:08 2008 +0000
     1.3 @@ -662,6 +662,10 @@ static int __devinit xenfb_probe(struct 
     1.4  	}
     1.5  	info->fb_info = fb_info;
     1.6  
     1.7 +	ret = xenfb_connect_backend(dev, info);
     1.8 +	if (ret < 0)
     1.9 +		goto error;
    1.10 +
    1.11  	/* FIXME should this be delayed until backend XenbusStateConnected? */
    1.12  	info->kthread = kthread_run(xenfb_thread, info, "xenfb thread");
    1.13  	if (IS_ERR(info->kthread)) {
    1.14 @@ -671,10 +675,6 @@ static int __devinit xenfb_probe(struct 
    1.15  		goto error;
    1.16  	}
    1.17  
    1.18 -	ret = xenfb_connect_backend(dev, info);
    1.19 -	if (ret < 0)
    1.20 -		goto error;
    1.21 -
    1.22  	return 0;
    1.23  
    1.24   error_nomem: