ia64/linux-2.6.18-xen.hg

annotate Documentation/SubmitChecklist @ 897:329ea0ccb344

balloon: try harder to balloon up under memory pressure.

Currently if the balloon driver is unable to increase the guest's
reservation it assumes the failure was due to reaching its full
allocation, gives up on the ballooning operation and records the limit
it reached as the "hard limit". The driver will not try again until
the target is set again (even to the same value).

However it is possible that ballooning has in fact failed due to
memory pressure in the host and therefore it is desirable to keep
attempting to reach the target in case memory becomes available. The
most likely scenario is that some guests are ballooning down while
others are ballooning up and therefore there is temporary memory
pressure while things stabilise. You would not expect a well behaved
toolstack to ask a domain to balloon to more than its allocation nor
would you expect it to deliberately over-commit memory by setting
balloon targets which exceed the total host memory.

This patch drops the concept of a hard limit and causes the balloon
driver to retry increasing the reservation on a timer in the same
manner as when decreasing the reservation.

Also if we partially succeed in increasing the reservation
(i.e. receive less pages than we asked for) then we may as well keep
those pages rather than returning them to Xen.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
author Keir Fraser <keir.fraser@citrix.com>
date Fri Jun 05 14:01:20 2009 +0100 (2009-06-05)
parents 831230e53067
children
rev   line source
ian@0 1 Linux Kernel patch sumbittal checklist
ian@0 2 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ian@0 3
ian@0 4 Here are some basic things that developers should do if they want to see their
ian@0 5 kernel patch submissions accepted more quickly.
ian@0 6
ian@0 7 These are all above and beyond the documentation that is provided in
ian@0 8 Documentation/SubmittingPatches and elsewhere regarding submitting Linux
ian@0 9 kernel patches.
ian@0 10
ian@0 11
ian@0 12
ian@0 13 1: Builds cleanly with applicable or modified CONFIG options =y, =m, and
ian@0 14 =n. No gcc warnings/errors, no linker warnings/errors.
ian@0 15
ian@0 16 2: Passes allnoconfig, allmodconfig
ian@0 17
ian@0 18 3: Builds on multiple CPU architectures by using local cross-compile tools
ian@0 19 or something like PLM at OSDL.
ian@0 20
ian@0 21 4: ppc64 is a good architecture for cross-compilation checking because it
ian@0 22 tends to use `unsigned long' for 64-bit quantities.
ian@0 23
ian@0 24 5: Matches kernel coding style(!)
ian@0 25
ian@0 26 6: Any new or modified CONFIG options don't muck up the config menu.
ian@0 27
ian@0 28 7: All new Kconfig options have help text.
ian@0 29
ian@0 30 8: Has been carefully reviewed with respect to relevant Kconfig
ian@0 31 combinations. This is very hard to get right with testing -- brainpower
ian@0 32 pays off here.
ian@0 33
ian@0 34 9: Check cleanly with sparse.
ian@0 35
ian@0 36 10: Use 'make checkstack' and 'make namespacecheck' and fix any problems
ian@0 37 that they find. Note: checkstack does not point out problems explicitly,
ian@0 38 but any one function that uses more than 512 bytes on the stack is a
ian@0 39 candidate for change.
ian@0 40
ian@0 41 11: Include kernel-doc to document global kernel APIs. (Not required for
ian@0 42 static functions, but OK there also.) Use 'make htmldocs' or 'make
ian@0 43 mandocs' to check the kernel-doc and fix any issues.
ian@0 44
ian@0 45 12: Has been tested with CONFIG_PREEMPT, CONFIG_DEBUG_PREEMPT,
ian@0 46 CONFIG_DEBUG_SLAB, CONFIG_DEBUG_PAGEALLOC, CONFIG_DEBUG_MUTEXES,
ian@0 47 CONFIG_DEBUG_SPINLOCK, CONFIG_DEBUG_SPINLOCK_SLEEP all simultaneously
ian@0 48 enabled.
ian@0 49
ian@0 50 13: Has been build- and runtime tested with and without CONFIG_SMP and
ian@0 51 CONFIG_PREEMPT.
ian@0 52
ian@0 53 14: If the patch affects IO/Disk, etc: has been tested with and without
ian@0 54 CONFIG_LBD.
ian@0 55
ian@0 56 15: All codepaths have been exercised with all lockdep features enabled.
ian@0 57
ian@0 58 16: All new /proc entries are documented under Documentation/
ian@0 59
ian@0 60 17: All new kernel boot parameters are documented in
ian@0 61 Documentation/kernel-parameters.txt.
ian@0 62
ian@0 63 18: All new module parameters are documented with MODULE_PARM_DESC()